chrome/common/metrics/caching_permuted_entropy_provider.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/metrics/caching_permuted_entropy_provider.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/common/metrics/caching_permuted_entropy_provider.cc

diff --git a/chrome/common/metrics/caching_permuted_entropy_provider.cc b/chrome/common/metrics/caching_permuted_entropy_provider.cc

index f58dee82e8688b332bacb99112885af95b4978c9..2432f3f97a0d05f91efef290a5728dd805e1d404 100644

--- a/chrome/common/metrics/caching_permuted_entropy_provider.cc

+++ b/chrome/common/metrics/caching_permuted_entropy_provider.cc

@@ -66,10 +66,7 @@ void CachingPermutedEntropyProvider::UpdateLocalState() const {

cache_.SerializeToString(&serialized);

std::string base64_encoded;

- if (!base::Base64Encode(serialized, &base64_encoded)) {

- NOTREACHED();

- return;

- }

+ base::Base64Encode(serialized, &base64_encoded);

local_state_->SetString(prefs::kMetricsPermutedEntropyCache, base64_encoded);

}