Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Side by Side Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One more chromeos-specific fix. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/ash/screenshot_taker.cc ('k') | chrome/browser/ui/certificate_dialogs.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h" 5 #include "chrome/browser/ui/autofill/autofill_dialog_controller_impl.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 10
(...skipping 2593 matching lines...) Expand 10 before | Expand all | Expand 10 after
2604 base::Bind(&AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData, 2604 base::Bind(&AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData,
2605 weak_ptr_factory_.GetWeakPtr())); 2605 weak_ptr_factory_.GetWeakPtr()));
2606 } 2606 }
2607 2607
2608 void AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData( 2608 void AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData(
2609 scoped_ptr<risk::Fingerprint> fingerprint) { 2609 scoped_ptr<risk::Fingerprint> fingerprint) {
2610 DCHECK(AreLegalDocumentsCurrent()); 2610 DCHECK(AreLegalDocumentsCurrent());
2611 2611
2612 std::string proto_data; 2612 std::string proto_data;
2613 fingerprint->SerializeToString(&proto_data); 2613 fingerprint->SerializeToString(&proto_data);
2614 bool success = base::Base64Encode(proto_data, &risk_data_); 2614 base::Base64Encode(proto_data, &risk_data_);
2615 DCHECK(success);
2616 2615
2617 SubmitWithWallet(); 2616 SubmitWithWallet();
2618 } 2617 }
2619 2618
2620 void AutofillDialogControllerImpl::OpenTabWithUrl(const GURL& url) { 2619 void AutofillDialogControllerImpl::OpenTabWithUrl(const GURL& url) {
2621 chrome::NavigateParams params( 2620 chrome::NavigateParams params(
2622 chrome::FindBrowserWithWebContents(web_contents()), 2621 chrome::FindBrowserWithWebContents(web_contents()),
2623 url, 2622 url,
2624 content::PAGE_TRANSITION_LINK); 2623 content::PAGE_TRANSITION_LINK);
2625 params.disposition = NEW_FOREGROUND_TAB; 2624 params.disposition = NEW_FOREGROUND_TAB;
(...skipping 913 matching lines...) Expand 10 before | Expand all | Expand 10 after
3539 view_->UpdateButtonStrip(); 3538 view_->UpdateButtonStrip();
3540 } 3539 }
3541 3540
3542 void AutofillDialogControllerImpl::FetchWalletCookie() { 3541 void AutofillDialogControllerImpl::FetchWalletCookie() {
3543 net::URLRequestContextGetter* request_context = profile_->GetRequestContext(); 3542 net::URLRequestContextGetter* request_context = profile_->GetRequestContext();
3544 signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context)); 3543 signin_helper_.reset(new wallet::WalletSigninHelper(this, request_context));
3545 signin_helper_->StartWalletCookieValueFetch(); 3544 signin_helper_->StartWalletCookieValueFetch();
3546 } 3545 }
3547 3546
3548 } // namespace autofill 3547 } // namespace autofill
OLDNEW
« no previous file with comments | « chrome/browser/ui/ash/screenshot_taker.cc ('k') | chrome/browser/ui/certificate_dialogs.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698