Make base::Base64Encode() return void

chrome/browser/bookmarks/bookmark_html_writer.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/bookmarks/bookmark_html_writer.h"
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/callback.h"
@@ skipping 252 matching lines @@
 
       std::string favicon_string;
       BookmarkFaviconFetcher::URLFaviconMap::iterator itr =
           favicons_map_->find(url_string);
       if (itr != favicons_map_->end()) {
         scoped_refptr<base::RefCountedMemory> data(itr->second.get());
         std::string favicon_data;
         favicon_data.assign(reinterpret_cast<const char*>(data->front()),
                             data->size());
         std::string favicon_base64_encoded;
-        if (base::Base64Encode(favicon_data, &favicon_base64_encoded)) {
-          GURL favicon_url("data:image/png;base64," + favicon_base64_encoded);
-          favicon_string = favicon_url.spec();
-        }
+        base::Base64Encode(favicon_data, &favicon_base64_encoded);
+        GURL favicon_url("data:image/png;base64," + favicon_base64_encoded);
+        favicon_string = favicon_url.spec();
       }
 
       if (!WriteIndent() ||
           !Write(kBookmarkStart) ||
           !Write(url_string, ATTRIBUTE_VALUE) ||
           !Write(kAddDate) ||
           !WriteTime(date_added_string) ||
           (!favicon_string.empty() &&
               (!Write(kIcon) ||
                !Write(favicon_string, ATTRIBUTE_VALUE))) ||
@@ skipping 215 matching lines @@
   // BookmarkModel isn't thread safe (nor would we want to lock it down
   // for the duration of the write), as such we make a copy of the
   // BookmarkModel using BookmarkCodec then write from that.
   if (fetcher == NULL) {
     fetcher = new BookmarkFaviconFetcher(profile, path, observer);
     fetcher->ExportBookmarks();
   }
 }
 
 }  // namespace bookmark_html_writer