Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1543)

Unified Diff: chrome/browser/extensions/extension_protocols.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One more chromeos-specific fix. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/extension_protocols.cc
diff --git a/chrome/browser/extensions/extension_protocols.cc b/chrome/browser/extensions/extension_protocols.cc
index 30a0cf26b4320ba45e792c84c3357b6d7c72fb80..ae0a0fbbdd2f7c64932d6d78a699b79e3c39de48 100644
--- a/chrome/browser/extensions/extension_protocols.cc
+++ b/chrome/browser/extensions/extension_protocols.cc
@@ -86,15 +86,14 @@ net::HttpResponseHeaders* BuildHttpHeaders(
last_modified_time.ToInternalValue());
hash = base::SHA1HashString(hash);
std::string etag;
- if (base::Base64Encode(hash, &etag)) {
- raw_headers.append(1, '\0');
- raw_headers.append("ETag: \"");
- raw_headers.append(etag);
- raw_headers.append("\"");
- // Also force revalidation.
- raw_headers.append(1, '\0');
- raw_headers.append("cache-control: no-cache");
- }
+ base::Base64Encode(hash, &etag);
+ raw_headers.append(1, '\0');
+ raw_headers.append("ETag: \"");
+ raw_headers.append(etag);
+ raw_headers.append("\"");
+ // Also force revalidation.
+ raw_headers.append(1, '\0');
+ raw_headers.append("cache-control: no-cache");
}
raw_headers.append(2, '\0');
« no previous file with comments | « chrome/browser/extensions/api/proxy/proxy_api_helpers.cc ('k') | chrome/browser/extensions/install_signer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698