sync/syncable/syncable_util.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/syncable/syncable_util.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/syncable/syncable_util.cc

diff --git a/sync/syncable/syncable_util.cc b/sync/syncable/syncable_util.cc

index 74ae06a001c4dcdf158f6cb269a32b67b95dee1f..d92aa47ed46d1e633da74123d3191010c46c27de 100644

--- a/sync/syncable/syncable_util.cc

+++ b/sync/syncable/syncable_util.cc

@@ -101,7 +101,7 @@ std::string GenerateSyncableHash(

hash_input.append(client_tag);

std::string encode_output;

- CHECK(base::Base64Encode(base::SHA1HashString(hash_input), &encode_output));

+ base::Base64Encode(base::SHA1HashString(hash_input), &encode_output);

return encode_output;

}

« no previous file with comments | « sync/protocol/proto_value_conversions.cc ('k') | sync/test/fake_encryptor.cc » ('j') | no next file with comments »