remoting/base/rsa_key_pair.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/base/rsa_key_pair.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/base/rsa_key_pair.cc

diff --git a/remoting/base/rsa_key_pair.cc b/remoting/base/rsa_key_pair.cc

index 1cea0774f2e4870e638f7bcd3be897eee35a511e..28dd2efa482325253a0faad93589428f349ac864 100644

--- a/remoting/base/rsa_key_pair.cc

+++ b/remoting/base/rsa_key_pair.cc

@@ -63,9 +63,7 @@ std::string RsaKeyPair::ToString() const {

CHECK(key_->ExportPrivateKey(&key_buf));

std::string key_str(key_buf.begin(), key_buf.end());

std::string key_base64;

- if (!base::Base64Encode(key_str, &key_base64)) {

- LOG(FATAL) << "Base64Encode failed";

- }

+ base::Base64Encode(key_str, &key_base64);

return key_base64;

}

« no previous file with comments | « net/websockets/websocket_handshake_handler.cc ('k') | remoting/host/pin_hash.cc » ('j') | no next file with comments »