net/websockets/websocket_basic_handshake_stream.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/websockets/websocket_basic_handshake_stream.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/websockets/websocket_basic_handshake_stream.cc

diff --git a/net/websockets/websocket_basic_handshake_stream.cc b/net/websockets/websocket_basic_handshake_stream.cc

index 1a8154b4b8b8b0863de003985825b593e756559b..8c0e42eb619609579b53f386ac9d73d3c703ff3e 100644

--- a/net/websockets/websocket_basic_handshake_stream.cc

+++ b/net/websockets/websocket_basic_handshake_stream.cc

@@ -33,8 +33,7 @@ std::string GenerateHandshakeChallenge() {

std::string raw_challenge(websockets::kRawChallengeLength, '\0');

crypto::RandBytes(string_as_array(&raw_challenge), raw_challenge.length());

std::string encoded_challenge;

- bool encode_success = base::Base64Encode(raw_challenge, &encoded_challenge);

- DCHECK(encode_success);

+ base::Base64Encode(raw_challenge, &encoded_challenge);

return encoded_challenge;

}