base/base64_unittest.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: base/base64_unittest.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: base/base64_unittest.cc

diff --git a/base/base64_unittest.cc b/base/base64_unittest.cc

index 9a5dd818e069a52fe5ee7463ddda6817c80022e8..9b23194ccf6587f20fafe549bfe97756a20dacaf 100644

--- a/base/base64_unittest.cc

+++ b/base/base64_unittest.cc

@@ -16,8 +16,7 @@ TEST(Base64Test, Basic) {

std::string decoded;

bool ok;

- ok = Base64Encode(kText, &encoded);

- EXPECT_TRUE(ok);

+ Base64Encode(kText, &encoded);

EXPECT_EQ(kBase64Text, encoded);

ok = Base64Decode(encoded, &decoded);

« no previous file with comments | « base/base64.cc ('k') | chrome/browser/bookmarks/bookmark_html_writer.cc » ('j') | no next file with comments »