net/cert/x509_certificate.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/x509_certificate.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/x509_certificate.cc

diff --git a/net/cert/x509_certificate.cc b/net/cert/x509_certificate.cc

index 862a202621069b0d4995ad07ed7416bfaf2e9e63..a095fdf83e9c530b733eb510e8145f7820095e95 100644

--- a/net/cert/x509_certificate.cc

+++ b/net/cert/x509_certificate.cc

@@ -665,8 +665,7 @@ bool X509Certificate::GetPEMEncodedFromDER(const std::string& der_encoded,

if (der_encoded.empty())

return false;

std::string b64_encoded;

- if (!base::Base64Encode(der_encoded, &b64_encoded) || b64_encoded.empty())

- return false;

+ base::Base64Encode(der_encoded, &b64_encoded);

*pem_encoded = "-----BEGIN CERTIFICATE-----\n";

// Divide the Base-64 encoded data into 64-character chunks, as per

« no previous file with comments | « net/base/keygen_handler_win.cc ('k') | net/http/http_auth_gssapi_posix.cc » ('j') | no next file with comments »