Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: extensions/common/extension.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: One more chromeos-specific fix. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/shell/renderer/webkit_test_runner.cc ('k') | google_apis/cup/client_update_protocol.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/extension.cc
diff --git a/extensions/common/extension.cc b/extensions/common/extension.cc
index 10e065b97f791fa7c270c748dd59f85714407db7..0a67983d3a23cf9fed5184a775e3fd1b567c2ceb 100644
--- a/extensions/common/extension.cc
+++ b/extensions/common/extension.cc
@@ -248,7 +248,10 @@ bool Extension::ParsePEMKeyBytes(const std::string& input,
// static
bool Extension::ProducePEM(const std::string& input, std::string* output) {
DCHECK(output);
- return (input.length() == 0) ? false : base::Base64Encode(input, output);
+ if (input.empty())
+ return false;
+ base::Base64Encode(input, output);
+ return true;
}
// static
« no previous file with comments | « content/shell/renderer/webkit_test_runner.cc ('k') | google_apis/cup/client_update_protocol.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698