chrome/browser/media/desktop_streams_registry.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/media/desktop_streams_registry.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/media/desktop_streams_registry.cc

diff --git a/chrome/browser/media/desktop_streams_registry.cc b/chrome/browser/media/desktop_streams_registry.cc

index 64e4160b47b4432ae01c3a88f5e77645a36fc467..05c2ba007cebdc65eaa128f6dfdfb43293b9ca89 100644

--- a/chrome/browser/media/desktop_streams_registry.cc

+++ b/chrome/browser/media/desktop_streams_registry.cc

@@ -20,10 +20,8 @@ std::string GenerateRandomStreamId() {

char buffer[kStreamIdLengthBytes];

crypto::RandBytes(buffer, arraysize(buffer));

std::string result;

- if (!base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),

- &result)) {

- LOG(FATAL) << "Base64Encode failed.";

- }

+ base::Base64Encode(base::StringPiece(buffer, arraysize(buffer)),

+ &result);

return result;

}