sync/internal_api/sync_encryption_handler_impl.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/sync_encryption_handler_impl.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/sync_encryption_handler_impl.cc

diff --git a/sync/internal_api/sync_encryption_handler_impl.cc b/sync/internal_api/sync_encryption_handler_impl.cc

index e468e6cda347e4840566079c30f8dbf4d0ae089a..34bf0335c8f6b31dbb010f1faf0472643442f665 100644

--- a/sync/internal_api/sync_encryption_handler_impl.cc

+++ b/sync/internal_api/sync_encryption_handler_impl.cc

@@ -692,8 +692,7 @@ bool SyncEncryptionHandlerImpl::SetKeystoreKeys(

// Note: in order to Pack the keys, they must all be base64 encoded (else

// JSON serialization fails).

- if (!base::Base64Encode(raw_keystore_key, &keystore_key_))

- return false;

+ base::Base64Encode(raw_keystore_key, &keystore_key_);

// Go through and save the old keystore keys. We always persist all keystore

// keys the server sends us.