net/base/keygen_handler_win.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/base/keygen_handler_win.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/base/keygen_handler_win.cc

diff --git a/net/base/keygen_handler_win.cc b/net/base/keygen_handler_win.cc

index e1d432ce40109f69e94544ba0340cf6c6b0025a2..59d90e8b40cad2e562efc82416328fa99c7169b2 100644

--- a/net/base/keygen_handler_win.cc

+++ b/net/base/keygen_handler_win.cc

@@ -211,10 +211,7 @@ std::string KeygenHandler::GenKeyAndSignChallenge() {

}

std::string result;

- if (!base::Base64Encode(spkac, &result)) {

- LOG(ERROR) << "Keygen failed: Couldn't convert signed key into base64";

- return std::string();

- }

+ base::Base64Encode(spkac, &result);

VLOG(1) << "Keygen succeeded";

return result;