chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

diff --git a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

index 41e65ea1dd3225598a7dba75cf9b3274166a2453..8e7e164ccde8a6a0a6ba29a9b383c21d3417c33e 100644

--- a/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

+++ b/chrome/browser/policy/cloud/component_cloud_policy_browsertest.cc

@@ -87,8 +87,9 @@ const char kTestPolicy2JSON[] = "{\"Another\":\"turn_it_off\"}";

// Same encoding as ResourceCache does for its keys.

bool Base64Encode(const std::string& value, std::string* encoded) {

- if (value.empty() || !base::Base64Encode(value, encoded))

+ if (value.empty())

return false;

+ base::Base64Encode(value, encoded);

base::ReplaceChars(*encoded, "+", "-", encoded);

base::ReplaceChars(*encoded, "/", "_", encoded);

return true;