remoting/protocol/auth_util.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/protocol/auth_util.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/protocol/auth_util.cc

diff --git a/remoting/protocol/auth_util.cc b/remoting/protocol/auth_util.cc

index 455963672c21aa362f7eac0c34a5cea361768a23..17263bfa0ede61e129d1eb47fd7f6f3c15b648f4 100644

--- a/remoting/protocol/auth_util.cc

+++ b/remoting/protocol/auth_util.cc

@@ -26,9 +26,7 @@ std::string GenerateSupportAuthToken(const std::string& jid,

const std::string& access_code) {

std::string sha256 = crypto::SHA256HashString(jid + " " + access_code);

std::string sha256_base64;

- if (!base::Base64Encode(sha256, &sha256_base64)) {

- LOG(FATAL) << "Failed to encode auth token";

- }

+ base::Base64Encode(sha256, &sha256_base64);

return sha256_base64;

}