Chromium Code Reviews Chromium Code Reviews
Issue 86913002:
Make base::Base64Encode() return void (Closed)
Base URL: http://git.chromium.org/chromium/src.git@master| OLD | NEW |
|---|---|
| 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. | 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. |
| 2 // Use of this source code is governed by a BSD-style license that can be | 2 // Use of this source code is governed by a BSD-style license that can be |
| 3 // found in the LICENSE file. | 3 // found in the LICENSE file. |
| 4 | 4 |
| 5 #ifndef BASE_BASE64_H__ | 5 #ifndef BASE_BASE64_H__ |
| 6 #define BASE_BASE64_H__ | 6 #define BASE_BASE64_H__ |
| 7 | 7 |
| 8 #include <string> | 8 #include <string> |
| 9 | 9 |
| 10 #include "base/base_export.h" | 10 #include "base/base_export.h" |
| 11 #include "base/strings/string_piece.h" | 11 #include "base/strings/string_piece.h" |
| 12 | 12 |
| 13 namespace base { | 13 namespace base { |
| 14 | 14 |
| 15 // Encodes the input string in base64. Returns true if successful and false | 15 // Encodes the input string in base64. Returns true. |
| 16 // otherwise. The output string is only modified if successful. | |
| 17 BASE_EXPORT bool Base64Encode(const StringPiece& input, std::string* output); | 16 BASE_EXPORT bool Base64Encode(const StringPiece& input, std::string* output); |
|
brettw
2013/12/05 06:33:57
It seems like we should just fix the return value
| |
| 18 | 17 |
| 19 // Decodes the base64 input string. Returns true if successful and false | 18 // Decodes the base64 input string. Returns true if successful and false |
| 20 // otherwise. The output string is only modified if successful. | 19 // otherwise. The output string is only modified if successful. |
| 21 BASE_EXPORT bool Base64Decode(const StringPiece& input, std::string* output); | 20 BASE_EXPORT bool Base64Decode(const StringPiece& input, std::string* output); |
| 22 | 21 |
| 23 } // namespace base | 22 } // namespace base |
| 24 | 23 |
| 25 #endif // BASE_BASE64_H__ | 24 #endif // BASE_BASE64_H__ |
| OLD | NEW |
