chrome/browser/extensions/install_signer.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/install_signer.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/install_signer.cc

diff --git a/chrome/browser/extensions/install_signer.cc b/chrome/browser/extensions/install_signer.cc

index a144b991b308051c1de6fedce010e7914150864f..eb04fe7fbafa22f7fbbe08e1ee56086ef90ce44d 100644

--- a/chrome/browser/extensions/install_signer.cc

+++ b/chrome/browser/extensions/install_signer.cc

@@ -115,7 +115,8 @@ bool HashWithMachineId(const std::string& salt, std::string* result) {

std::string result_bytes(crypto::kSHA256Length, 0);

hash->Finish(string_as_array(&result_bytes), result_bytes.size());

- return base::Base64Encode(result_bytes, result);

+ base::Base64Encode(result_bytes, result);

+ return true;

}

} // namespace

« no previous file with comments | « chrome/browser/extensions/extension_protocols.cc ('k') | chrome/browser/internal_auth.cc » ('j') | no next file with comments »