chrome/browser/ui/certificate_dialogs.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/certificate_dialogs.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/certificate_dialogs.cc

diff --git a/chrome/browser/ui/certificate_dialogs.cc b/chrome/browser/ui/certificate_dialogs.cc

index d2000364c70d2fc489688b130631d7cf766eacab..cb32713de0bf104f4552cad750c59b2c32c37429 100644

--- a/chrome/browser/ui/certificate_dialogs.cc

+++ b/chrome/browser/ui/certificate_dialogs.cc

@@ -49,11 +49,7 @@ std::string WrapAt64(const std::string &str) {

std::string GetBase64String(net::X509Certificate::OSCertHandle cert) {

std::string base64;

- if (!base::Base64Encode(

- x509_certificate_model::GetDerString(cert), &base64)) {

- LOG(ERROR) << "base64 encoding error";

- return std::string();

- }

+ base::Base64Encode(x509_certificate_model::GetDerString(cert), &base64);

return "-----BEGIN CERTIFICATE-----\r\n" +

WrapAt64(base64) +

"-----END CERTIFICATE-----\r\n";