chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

diff --git a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

index 0d704051ea9f9785598a9b5a570c8cb277dc6a5c..1cfd4e763debe5856ca32bd8693ff13e8d6ee463 100644

--- a/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

+++ b/chrome/browser/ui/autofill/autofill_dialog_controller_impl.cc

@@ -2611,8 +2611,7 @@ void AutofillDialogControllerImpl::OnDidLoadRiskFingerprintData(

std::string proto_data;

fingerprint->SerializeToString(&proto_data);

- bool success = base::Base64Encode(proto_data, &risk_data_);

- DCHECK(success);

+ base::Base64Encode(proto_data, &risk_data_);

SubmitWithWallet();

}

« no previous file with comments | « chrome/browser/ui/ash/screenshot_taker.cc ('k') | chrome/browser/ui/certificate_dialogs.cc » ('j') | no next file with comments »