chrome/browser/metrics/variations/variations_service.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/variations/variations_service.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/variations/variations_service.cc

diff --git a/chrome/browser/metrics/variations/variations_service.cc b/chrome/browser/metrics/variations/variations_service.cc

index 95e9905def1b5654adf566f12e32520894347a9a..d93c2f19021854a3bd2ac1a57b30d1c126502160 100644

--- a/chrome/browser/metrics/variations/variations_service.cc

+++ b/chrome/browser/metrics/variations/variations_service.cc

@@ -481,11 +481,7 @@ bool VariationsService::StoreSeedData(const std::string& seed_data,

}

std::string base64_seed_data;

- if (!base::Base64Encode(seed_data, &base64_seed_data)) {

- VLOG(1) << "Variations Seed data from server fails Base64Encode, rejecting "

- << "the seed.";

- return false;

- }

+ base::Base64Encode(seed_data, &base64_seed_data);

local_state_->SetString(prefs::kVariationsSeed, base64_seed_data);

local_state_->SetString(prefs::kVariationsSeedHash, HashSeed(seed_data));