remoting/host/pin_hash.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/host/pin_hash.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: remoting/host/pin_hash.cc

diff --git a/remoting/host/pin_hash.cc b/remoting/host/pin_hash.cc

index fe17f38caff4d46e4fd812462bb7b9788c94e317..c9b1ca3cb6575acc0b48fd1510c9bba5cd82c804 100644

--- a/remoting/host/pin_hash.cc

+++ b/remoting/host/pin_hash.cc

@@ -16,9 +16,7 @@ std::string MakeHostPinHash(const std::string& host_id,

std::string hash = protocol::AuthenticationMethod::ApplyHashFunction(

protocol::AuthenticationMethod::HMAC_SHA256, host_id, pin);

std::string hash_base64;

- if (!base::Base64Encode(hash, &hash_base64)) {

- LOG(FATAL) << "Base64Encode failed";

- }

+ base::Base64Encode(hash, &hash_base64);

return "hmac:" + hash_base64;

}

« no previous file with comments | « remoting/base/rsa_key_pair.cc ('k') | remoting/host/token_validator_factory_impl.cc » ('j') | no next file with comments »