chrome/browser/internal_auth.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/internal_auth.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/internal_auth.cc

diff --git a/chrome/browser/internal_auth.cc b/chrome/browser/internal_auth.cc

index ed8ff26234771bcd022f83fd774fc8ce8cd6b29f..984c95477139b59af208050f1cb040f329945e4d 100644

--- a/chrome/browser/internal_auth.cc

+++ b/chrome/browser/internal_auth.cc

@@ -166,10 +166,7 @@ void CreatePassport(const std::string& domain,

return;

}

std::string hmac_base64;

- if (!base::Base64Encode(hmac, &hmac_base64)) {

- NOTREACHED();

- return;

- }

+ base::Base64Encode(hmac, &hmac_base64);

if (hmac_base64.size() != BASE64_PER_RAW(kHMACSizeInBytes)) {

NOTREACHED();

return;