chrome/browser/extensions/api/proxy/proxy_api_helpers.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/proxy/proxy_api_helpers.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/api/proxy/proxy_api_helpers.cc

diff --git a/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc b/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc

index fa88fbdb714ce1e59eae332017236d1cd4707ed3..69d9ccb1271989c18cef596cc5e59c9ca737039c 100644

--- a/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc

+++ b/chrome/browser/extensions/api/proxy/proxy_api_helpers.cc

@@ -35,8 +35,7 @@ bool CreateDataURLFromPACScript(const std::string& pac_script,

std::string* pac_script_url_base64_encoded) {

// Encode pac_script in base64.

std::string pac_script_base64_encoded;

- if (!base::Base64Encode(pac_script, &pac_script_base64_encoded))

- return false;

+ base::Base64Encode(pac_script, &pac_script_base64_encoded);

// Make it a correct data url.

*pac_script_url_base64_encoded =