sync/internal_api/public/base/unique_position_unittest.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/public/base/unique_position_unittest.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/public/base/unique_position_unittest.cc

diff --git a/sync/internal_api/public/base/unique_position_unittest.cc b/sync/internal_api/public/base/unique_position_unittest.cc

index 371874ae4ee51d57fdb0c406ed43fde231d9f528..4c0a66047f1aea3363d6b68db37f0d5af975b96b 100644

--- a/sync/internal_api/public/base/unique_position_unittest.cc

+++ b/sync/internal_api/public/base/unique_position_unittest.cc

@@ -392,7 +392,7 @@ class SuffixGenerator {

// random anyway.

std::string input = cache_guid_ + base::Int64ToString(next_id_--);

std::string output;

- CHECK(base::Base64Encode(base::SHA1HashString(input), &output));

+ base::Base64Encode(base::SHA1HashString(input), &output);

return output;

}