chrome/browser/metrics/metrics_log_serializer.cc - Issue 86913002: Make base::Base64Encode() return void

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/metrics/metrics_log_serializer.cc

Issue 86913002: Make base::Base64Encode() return void (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: One more chromeos-specific fix. Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/metrics/metrics_log_serializer.cc

diff --git a/chrome/browser/metrics/metrics_log_serializer.cc b/chrome/browser/metrics/metrics_log_serializer.cc

index 8283ccd2257ec7ba6d332f3bf55e03d12d4245c4..e25b379ff4cc0057bf14d8872303105f0aff1c0b 100644

--- a/chrome/browser/metrics/metrics_log_serializer.cc

+++ b/chrome/browser/metrics/metrics_log_serializer.cc

@@ -141,10 +141,7 @@ void MetricsLogSerializer::WriteLogsToPrefList(

it != local_list.end(); ++it) {

// We encode the compressed log as Value::CreateStringValue() expects to

// take a valid UTF8 string.

- if (!base::Base64Encode(it->log_text(), &encoded_log)) {

- list->Clear();

- return;

- }

+ base::Base64Encode(it->log_text(), &encoded_log);

base::MD5Update(&ctx, encoded_log);

list->Append(Value::CreateStringValue(encoded_log));

}