Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed)

Created:
6 years, 2 months ago by dcheng
Modified:
6 years, 2 months ago
Reviewers:
Lei Zhang
CC:
aandrey+blink_chromium.org, cbentzel+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, chromoting-reviews_chromium.org, devtools-reviews_chromium.org, extensions-reviews_chromium.org, jam, mkwst+moarreviews-ipc_chromium.org, native-client-reviews_googlegroups.com, paulirish+reviews_chromium.org, pfeldman, piman+watch_chromium.org, rginda+watch_chromium.org, samuong+watch_chromium.org, stgao, stuartmorgan+watch_chromium.org, tfarina, vsevik, yoshiki+watch_chromium.org, yurys
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Standardize usage of virtual/override/final in chrome/ This patch was automatically generated by applying clang fixit hints generated by the plugin to the source tree. BUG=417463 TBR=thestig@chromium.org Committed: https://crrev.com/e59c1bb95b7f2f381d6a0c38c6f6f1c9a89c4ed4 Cr-Commit-Position: refs/heads/master@{#300465}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1238 lines, -1398 lines) Patch
M chrome/app/chrome_crash_reporter_client.h View 3 chunks +9 lines, -10 lines 0 comments Download
M chrome/app/chrome_main_delegate.h View 2 chunks +13 lines, -15 lines 0 comments Download
M chrome/app_shim/chrome_main_app_mode_mac.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/chrome_content_client.h View 1 chunk +13 lines, -14 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_handler.h View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/extension_action/action_info.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/page_action_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/file_browser_handlers/file_browser_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_handler.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/api/input_ime/input_components_handler.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/api/omnibox/omnibox_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/plugins/plugins_handler.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/speech/tts_engine_manifest_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/spellcheck/spellcheck_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/storage/storage_schema_manifest_handler.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/api/supervised_user_private/supervised_user_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/api/system_indicator/system_indicator_handler.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/url_handlers/url_handlers_parser.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/chrome_extensions_client.h View 1 chunk +19 lines, -22 lines 0 comments Download
M chrome/common/extensions/chrome_manifest_url_handlers.h View 3 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/features/chrome_channel_feature_filter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_isolation_info.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/app_launch_info.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation.h View 2 chunks +6 lines, -6 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/automation.cc View 1 chunk +9 lines, -12 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/content_scripts_handler.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/extension_action_handler.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/mime_types_handler.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/mime_types_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handlers/minimum_chrome_version_checker.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/settings_overrides_handler.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/theme_handler.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.h View 2 chunks +9 lines, -9 lines 0 comments Download
M chrome/common/extensions/manifest_handlers/ui_overrides_handler.cc View 4 chunks +9 lines, -16 lines 0 comments Download
M chrome/common/extensions/manifest_tests/chrome_manifest_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/permissions/chrome_api_permissions.h View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/common/extensions/permissions/chrome_permission_message_provider.h View 1 chunk +7 lines, -8 lines 0 comments Download
M chrome/common/icon_with_badge_image_source.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/ini_parser.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/common/ini_parser_unittest.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/common/mac/mock_launchd.h View 1 chunk +17 lines, -21 lines 0 comments Download
M chrome/common/multi_process_lock_mac.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/common/service_process_util_posix.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/worker_thread_ticker_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/plugin/chrome_content_plugin_client.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/cloud_print/cloud_print_auth.h View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_connector.h View 1 chunk +8 lines, -8 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy.h View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_proxy_backend.cc View 1 chunk +12 lines, -13 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc View 10 chunks +13 lines, -15 lines 0 comments Download
M chrome/service/cloud_print/cloud_print_wipeout.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/service/cloud_print/job_status_updater.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/print_system_cups.cc View 10 chunks +32 lines, -38 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler.h View 2 chunks +14 lines, -14 lines 0 comments Download
M chrome/service/cloud_print/printer_job_handler_unittest.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/service/cloud_print/printer_job_queue_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/service/net/service_url_request_context_getter.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/service/service_ipc_server.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/service/service_process.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/service/service_process.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/browser_perf_tests_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/browser_tests_main.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_process_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_host_test_harness.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 1 chunk +3 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_test_launcher.cc View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/test/base/chrome_test_suite.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/chrome_unit_test_suite.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/find_in_page_observer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/history_index_restore_observer.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/in_process_browser_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/in_process_browser_test_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/interactive_ui_tests_main.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/base/javascript_browser_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/menu_model_test.h View 1 chunk +5 lines, -6 lines 0 comments Download
M chrome/test/base/test_browser_window.h View 1 chunk +121 lines, -125 lines 0 comments Download
M chrome/test/base/test_browser_window.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/test/base/test_chrome_web_ui_controller_factory.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/base/testing_browser_process.h View 2 chunks +52 lines, -55 lines 0 comments Download
M chrome/test/base/testing_browser_process_platform_part.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_pref_service_syncable.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/testing_profile.h View 4 chunks +49 lines, -54 lines 0 comments Download
M chrome/test/base/testing_profile.cc View 3 chunks +11 lines, -15 lines 0 comments Download
M chrome/test/base/testing_profile_manager.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/base/tracing.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/base/ui_test_utils.h View 2 chunks +7 lines, -7 lines 0 comments Download
M chrome/test/base/view_event_test_platform_part_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/base/web_ui_browser_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/base/web_ui_browser_test.cc View 5 chunks +7 lines, -8 lines 0 comments Download
M chrome/test/chromedriver/chrome/adb_impl.h View 1 chunk +22 lines, -22 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_android_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_desktop_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_impl.h View 1 chunk +10 lines, -11 lines 0 comments Download
M chrome/test/chromedriver/chrome/chrome_remote_impl.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/console_logger.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/console_logger_unittest.cc View 4 chunks +9 lines, -13 lines 0 comments Download
M chrome/test/chromedriver/chrome/debugger_tracker.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/device_manager_unittest.cc View 1 chunk +23 lines, -23 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_client_impl.h View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/test/chromedriver/chrome/devtools_client_impl_unittest.cc View 22 chunks +82 lines, -130 lines 0 comments Download
M chrome/test/chromedriver/chrome/dom_tracker.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/dom_tracker_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/frame_tracker.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/geolocation_override_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/geolocation_override_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/heap_snapshot_taker.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/heap_snapshot_taker_unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/test/chromedriver/chrome/javascript_dialog_manager.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/javascript_dialog_manager_unittest.cc View 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/mobile_emulation_override_manager.h View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/chrome/mobile_emulation_override_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker.h View 1 chunk +7 lines, -7 lines 0 comments Download
M chrome/test/chromedriver/chrome/navigation_tracker_unittest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_chrome.h View 1 chunk +11 lines, -12 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_devtools_client.h View 1 chunk +11 lines, -11 lines 0 comments Download
M chrome/test/chromedriver/chrome/stub_web_view.h View 1 chunk +48 lines, -52 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl.h View 1 chunk +48 lines, -52 lines 0 comments Download
M chrome/test/chromedriver/chrome/web_view_impl_unittest.cc View 3 chunks +11 lines, -20 lines 0 comments Download
M chrome/test/chromedriver/command_listener_proxy.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/command_listener_proxy_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/commands_unittest.cc View 5 chunks +14 lines, -14 lines 0 comments Download
M chrome/test/chromedriver/logging.h View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/test/chromedriver/net/net_util.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/chromedriver/net/net_util_unittest.cc View 2 chunks +8 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/net/sync_websocket_impl.h View 2 chunks +10 lines, -11 lines 0 comments Download
M chrome/test/chromedriver/net/test_http_server.h View 1 chunk +7 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/net/url_request_context_getter.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/test/chromedriver/net/websocket_unittest.cc View 3 chunks +6 lines, -12 lines 0 comments Download
M chrome/test/chromedriver/performance_logger.h View 1 chunk +6 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/performance_logger_unittest.cc View 5 chunks +12 lines, -17 lines 0 comments Download
M chrome/test/chromedriver/server/chromedriver_server.cc View 1 chunk +8 lines, -9 lines 0 comments Download
M chrome/test/chromedriver/session_commands_unittest.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/test/chromedriver/session_unittest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/data/webui/chrome_send_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/data/webui/history_ui_browsertest.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/gpu/webgl_infobar_browsertest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/nacl/nacl_browsertest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_uma.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.h View 5 chunks +17 lines, -18 lines 0 comments Download
M chrome/test/nacl/nacl_browsertest_util.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/test/nacl/pnacl_header_test.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/test/perf/browser_perf_test.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/remoting/page_load_notification_observer.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/remoting/remote_desktop_browsertest.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/test/remoting/waiter.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/extensions/extensions_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/image_writer/image_writer_handler.h View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/utility/image_writer/image_writer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/utility/importer/bookmarks_file_importer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/utility/importer/external_process_importer_bridge.h View 1 chunk +17 lines, -20 lines 0 comments Download
M chrome/utility/importer/firefox_importer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/utility/importer/firefox_importer_unittest_utils_mac.cc View 4 chunks +4 lines, -6 lines 0 comments Download
M chrome/utility/importer/safari_importer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/utility/media_galleries/ipc_data_source.h View 1 chunk +10 lines, -8 lines 0 comments Download
M chrome/utility/media_galleries/iphoto_library_parser.cc View 6 chunks +9 lines, -17 lines 0 comments Download
M chrome/utility/media_galleries/itunes_library_parser.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/utility/media_galleries/picasa_albums_indexer.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/utility/printing_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/profile_import_handler.h View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
dcheng
6 years, 2 months ago (2014-10-21 10:36:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/653773004/1
6 years, 2 months ago (2014-10-21 10:37:56 UTC) #3
Lei Zhang
lgtm
6 years, 2 months ago (2014-10-21 10:51:15 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years, 2 months ago (2014-10-21 11:56:07 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-21 11:56:36 UTC) #6
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/e59c1bb95b7f2f381d6a0c38c6f6f1c9a89c4ed4
Cr-Commit-Position: refs/heads/master@{#300465}

Powered by Google App Engine
This is Rietveld 408576698