chrome/common/extensions/manifest_handlers/automation.cc - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/automation.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/automation.h ('k') | chrome/common/extensions/manifest_handlers/content_scripts_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/automation.cc

diff --git a/chrome/common/extensions/manifest_handlers/automation.cc b/chrome/common/extensions/manifest_handlers/automation.cc

index ea9fd7e8f540f689fc8b98bb72bd514e722333be..c5b24af0d04b9d5c99fe6b3b631b90ddf72c152d 100644

--- a/chrome/common/extensions/manifest_handlers/automation.cc

+++ b/chrome/common/extensions/manifest_handlers/automation.cc

@@ -44,26 +44,23 @@ class AutomationManifestPermission : public ManifestPermission {

: automation_info_(automation_info.Pass()) {}

// extensions::ManifestPermission overrides.

- virtual std::string name() const override;

+ std::string name() const override;

- virtual std::string id() const override;

+ std::string id() const override;

- virtual bool HasMessages() const override;

+ bool HasMessages() const override;

- virtual PermissionMessages GetMessages() const override;

+ PermissionMessages GetMessages() const override;

- virtual bool FromValue(const base::Value* value) override;

+ bool FromValue(const base::Value* value) override;

- virtual scoped_ptr<base::Value> ToValue() const override;

+ scoped_ptr<base::Value> ToValue() const override;

- virtual ManifestPermission* Diff(

- const ManifestPermission* rhs) const override;

+ ManifestPermission* Diff(const ManifestPermission* rhs) const override;

- virtual ManifestPermission* Union(

- const ManifestPermission* rhs) const override;

+ ManifestPermission* Union(const ManifestPermission* rhs) const override;

- virtual ManifestPermission* Intersect(

- const ManifestPermission* rhs) const override;

+ ManifestPermission* Intersect(const ManifestPermission* rhs) const override;

private:

scoped_ptr<const AutomationInfo> automation_info_;