Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1035)

Side by Side Diff: chrome/common/extensions/manifest_handlers/settings_overrides_handler.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_ 5 #ifndef CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_
6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_ 6 #define CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER_H_
7 7
8 #include "chrome/common/extensions/api/manifest_types.h" 8 #include "chrome/common/extensions/api/manifest_types.h"
9 #include "extensions/common/extension.h" 9 #include "extensions/common/extension.h"
10 #include "extensions/common/manifest_handler.h" 10 #include "extensions/common/manifest_handler.h"
11 11
12 namespace extensions { 12 namespace extensions {
13 13
14 enum SettingsApiOverrideType { 14 enum SettingsApiOverrideType {
15 BUBBLE_TYPE_HOME_PAGE = 0, 15 BUBBLE_TYPE_HOME_PAGE = 0,
16 BUBBLE_TYPE_SEARCH_ENGINE, 16 BUBBLE_TYPE_SEARCH_ENGINE,
17 BUBBLE_TYPE_STARTUP_PAGES, 17 BUBBLE_TYPE_STARTUP_PAGES,
18 }; 18 };
19 19
20 class ManifestPermission; 20 class ManifestPermission;
21 21
22 // SettingsOverride is associated with "chrome_settings_overrides" manifest key. 22 // SettingsOverride is associated with "chrome_settings_overrides" manifest key.
23 // An extension can add a search engine as default or non-default, overwrite the 23 // An extension can add a search engine as default or non-default, overwrite the
24 // homepage and append a startup page to the list. 24 // homepage and append a startup page to the list.
25 struct SettingsOverrides : public Extension::ManifestData { 25 struct SettingsOverrides : public Extension::ManifestData {
26 SettingsOverrides(); 26 SettingsOverrides();
27 virtual ~SettingsOverrides(); 27 ~SettingsOverrides() override;
28 28
29 static const SettingsOverrides* Get(const Extension* extension); 29 static const SettingsOverrides* Get(const Extension* extension);
30 30
31 scoped_ptr<api::manifest_types::ChromeSettingsOverrides::Search_provider> 31 scoped_ptr<api::manifest_types::ChromeSettingsOverrides::Search_provider>
32 search_engine; 32 search_engine;
33 scoped_ptr<GURL> homepage; 33 scoped_ptr<GURL> homepage;
34 std::vector<GURL> startup_pages; 34 std::vector<GURL> startup_pages;
35 35
36 private: 36 private:
37 DISALLOW_COPY_AND_ASSIGN(SettingsOverrides); 37 DISALLOW_COPY_AND_ASSIGN(SettingsOverrides);
38 }; 38 };
39 39
40 class SettingsOverridesHandler : public ManifestHandler { 40 class SettingsOverridesHandler : public ManifestHandler {
41 public: 41 public:
42 SettingsOverridesHandler(); 42 SettingsOverridesHandler();
43 virtual ~SettingsOverridesHandler(); 43 ~SettingsOverridesHandler() override;
44 44
45 virtual bool Parse(Extension* extension, base::string16* error) override; 45 bool Parse(Extension* extension, base::string16* error) override;
46 46
47 private: 47 private:
48 virtual const std::vector<std::string> Keys() const override; 48 const std::vector<std::string> Keys() const override;
49 49
50 DISALLOW_COPY_AND_ASSIGN(SettingsOverridesHandler); 50 DISALLOW_COPY_AND_ASSIGN(SettingsOverridesHandler);
51 }; 51 };
52 52
53 } // namespace extensions 53 } // namespace extensions
54 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER _H_ 54 #endif // CHROME_COMMON_EXTENSIONS_MANIFEST_HANDLERS_SETTINGS_OVERRIDES_HANDLER _H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698