Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5828)

Unified Diff: chrome/test/chromedriver/chrome/adb_impl.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/web_ui_browser_test.cc ('k') | chrome/test/chromedriver/chrome/chrome_android_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/adb_impl.h
diff --git a/chrome/test/chromedriver/chrome/adb_impl.h b/chrome/test/chromedriver/chrome/adb_impl.h
index 043986d3d5906525c701ecfa7b0f3e8cdad98e89..895bd7890436d1b84f06cd1ecfb7289ad4b3b6e8 100644
--- a/chrome/test/chromedriver/chrome/adb_impl.h
+++ b/chrome/test/chromedriver/chrome/adb_impl.h
@@ -23,31 +23,31 @@ class AdbImpl : public Adb {
explicit AdbImpl(
const scoped_refptr<base::SingleThreadTaskRunner>& io_message_loop_proxy,
int port);
- virtual ~AdbImpl();
+ ~AdbImpl() override;
// Overridden from Adb:
- virtual Status GetDevices(std::vector<std::string>* devices) override;
- virtual Status ForwardPort(const std::string& device_serial,
- int local_port,
- const std::string& remote_abstract) override;
- virtual Status SetCommandLineFile(const std::string& device_serial,
- const std::string& command_line_file,
- const std::string& exec_name,
- const std::string& args) override;
- virtual Status CheckAppInstalled(const std::string& device_serial,
- const std::string& package) override;
- virtual Status ClearAppData(const std::string& device_serial,
- const std::string& package) override;
- virtual Status SetDebugApp(const std::string& device_serial,
- const std::string& package) override;
- virtual Status Launch(const std::string& device_serial,
- const std::string& package,
- const std::string& activity) override;
- virtual Status ForceStop(const std::string& device_serial,
+ Status GetDevices(std::vector<std::string>* devices) override;
+ Status ForwardPort(const std::string& device_serial,
+ int local_port,
+ const std::string& remote_abstract) override;
+ Status SetCommandLineFile(const std::string& device_serial,
+ const std::string& command_line_file,
+ const std::string& exec_name,
+ const std::string& args) override;
+ Status CheckAppInstalled(const std::string& device_serial,
const std::string& package) override;
- virtual Status GetPidByName(const std::string& device_serial,
- const std::string& process_name,
- int* pid) override;
+ Status ClearAppData(const std::string& device_serial,
+ const std::string& package) override;
+ Status SetDebugApp(const std::string& device_serial,
+ const std::string& package) override;
+ Status Launch(const std::string& device_serial,
+ const std::string& package,
+ const std::string& activity) override;
+ Status ForceStop(const std::string& device_serial,
+ const std::string& package) override;
+ Status GetPidByName(const std::string& device_serial,
+ const std::string& process_name,
+ int* pid) override;
private:
Status ExecuteCommand(const std::string& command,
« no previous file with comments | « chrome/test/base/web_ui_browser_test.cc ('k') | chrome/test/chromedriver/chrome/chrome_android_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698