Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3286)

Unified Diff: chrome/test/chromedriver/net/sync_websocket_impl.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/net/net_util_unittest.cc ('k') | chrome/test/chromedriver/net/test_http_server.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/net/sync_websocket_impl.h
diff --git a/chrome/test/chromedriver/net/sync_websocket_impl.h b/chrome/test/chromedriver/net/sync_websocket_impl.h
index 4a42471789a85be0eecb11ab23780403992920a9..32896ee330f21300991fce1363642e0c18dd1db3 100644
--- a/chrome/test/chromedriver/net/sync_websocket_impl.h
+++ b/chrome/test/chromedriver/net/sync_websocket_impl.h
@@ -32,16 +32,15 @@ class GURL;
class SyncWebSocketImpl : public SyncWebSocket {
public:
explicit SyncWebSocketImpl(net::URLRequestContextGetter* context_getter);
- virtual ~SyncWebSocketImpl();
+ ~SyncWebSocketImpl() override;
// Overridden from SyncWebSocket:
- virtual bool IsConnected() override;
- virtual bool Connect(const GURL& url) override;
- virtual bool Send(const std::string& message) override;
- virtual StatusCode ReceiveNextMessage(
- std::string* message,
- const base::TimeDelta& timeout) override;
- virtual bool HasNextMessage() override;
+ bool IsConnected() override;
+ bool Connect(const GURL& url) override;
+ bool Send(const std::string& message) override;
+ StatusCode ReceiveNextMessage(std::string* message,
+ const base::TimeDelta& timeout) override;
+ bool HasNextMessage() override;
private:
struct CoreTraits;
@@ -59,15 +58,15 @@ class SyncWebSocketImpl : public SyncWebSocket {
bool HasNextMessage();
// Overriden from WebSocketListener:
- virtual void OnMessageReceived(const std::string& message) override;
- virtual void OnClose() override;
+ void OnMessageReceived(const std::string& message) override;
+ void OnClose() override;
private:
friend class base::RefCountedThreadSafe<Core, CoreTraits>;
friend class base::DeleteHelper<Core>;
friend struct CoreTraits;
- virtual ~Core();
+ ~Core() override;
void ConnectOnIO(const GURL& url,
bool* success,
« no previous file with comments | « chrome/test/chromedriver/net/net_util_unittest.cc ('k') | chrome/test/chromedriver/net/test_http_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698