Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/test/base/test_chrome_web_ui_controller_factory.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/base/test_browser_window.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/base/test_chrome_web_ui_controller_factory.h
diff --git a/chrome/test/base/test_chrome_web_ui_controller_factory.h b/chrome/test/base/test_chrome_web_ui_controller_factory.h
index 03f7bf766a2d24ba9efd561085262d270608680a..ceb4af923dbdf92f35213a1cbd9b2b0052c5399a 100644
--- a/chrome/test/base/test_chrome_web_ui_controller_factory.h
+++ b/chrome/test/base/test_chrome_web_ui_controller_factory.h
@@ -32,7 +32,7 @@ class TestChromeWebUIControllerFactory : public ChromeWebUIControllerFactory {
typedef std::map<std::string, WebUIProvider*> FactoryOverridesMap;
TestChromeWebUIControllerFactory();
- virtual ~TestChromeWebUIControllerFactory();
+ ~TestChromeWebUIControllerFactory() override;
// Override the creation for urls having |host| with |provider|.
void AddFactoryOverride(const std::string& host, WebUIProvider* provider);
@@ -41,11 +41,11 @@ class TestChromeWebUIControllerFactory : public ChromeWebUIControllerFactory {
void RemoveFactoryOverride(const std::string& host);
// ChromeWebUIFactory overrides.
- virtual content::WebUI::TypeID GetWebUIType(
- content::BrowserContext* browser_context,
+ content::WebUI::TypeID GetWebUIType(content::BrowserContext* browser_context,
+ const GURL& url) const override;
+ content::WebUIController* CreateWebUIControllerForURL(
+ content::WebUI* web_ui,
const GURL& url) const override;
- virtual content::WebUIController* CreateWebUIControllerForURL(
- content::WebUI* web_ui, const GURL& url) const override;
private:
// Return the WebUIProvider for the |url|'s host if it exists, otherwise NULL.
« no previous file with comments | « chrome/test/base/test_browser_window.cc ('k') | chrome/test/base/testing_browser_process.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698