Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Unified Diff: chrome/test/chromedriver/chrome/web_view_impl_unittest.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.h ('k') | chrome/test/chromedriver/command_listener_proxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc b/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
index 9e6663a23d85dcb167379514d6c04e59c803b1df..febaa7b0a05b930c7632b6b49dc9fc9490f74b8c 100644
--- a/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
+++ b/chrome/test/chromedriver/chrome/web_view_impl_unittest.cc
@@ -18,7 +18,7 @@ namespace {
class FakeDevToolsClient : public DevToolsClient {
public:
FakeDevToolsClient() : id_("fake-id"), status_(kOk) {}
- virtual ~FakeDevToolsClient() {}
+ ~FakeDevToolsClient() override {}
void set_status(const Status& status) {
status_ = status;
@@ -29,20 +29,14 @@ class FakeDevToolsClient : public DevToolsClient {
}
// Overridden from DevToolsClient:
- virtual const std::string& GetId() override {
- return id_;
- }
- virtual bool WasCrashed() override {
- return false;
- }
- virtual Status ConnectIfNecessary() override {
- return Status(kOk);
- }
- virtual Status SendCommand(const std::string& method,
- const base::DictionaryValue& params) override {
+ const std::string& GetId() override { return id_; }
+ bool WasCrashed() override { return false; }
+ Status ConnectIfNecessary() override { return Status(kOk); }
+ Status SendCommand(const std::string& method,
+ const base::DictionaryValue& params) override {
return SendCommandAndGetResult(method, params, NULL);
}
- virtual Status SendCommandAndGetResult(
+ Status SendCommandAndGetResult(
const std::string& method,
const base::DictionaryValue& params,
scoped_ptr<base::DictionaryValue>* result) override {
@@ -51,15 +45,12 @@ class FakeDevToolsClient : public DevToolsClient {
result->reset(result_.DeepCopy());
return Status(kOk);
}
- virtual void AddListener(DevToolsEventListener* listener) override {}
- virtual Status HandleEventsUntil(
- const ConditionalFunc& conditional_func,
- const base::TimeDelta& timeout) override {
- return Status(kOk);
- }
- virtual Status HandleReceivedEvents() override {
+ void AddListener(DevToolsEventListener* listener) override {}
+ Status HandleEventsUntil(const ConditionalFunc& conditional_func,
+ const base::TimeDelta& timeout) override {
return Status(kOk);
}
+ Status HandleReceivedEvents() override { return Status(kOk); }
private:
const std::string id_;
« no previous file with comments | « chrome/test/chromedriver/chrome/web_view_impl.h ('k') | chrome/test/chromedriver/command_listener_proxy.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698