chrome/utility/importer/firefox_importer.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/utility/importer/firefox_importer.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/utility/importer/external_process_importer_bridge.h ('k') | chrome/utility/importer/firefox_importer_unittest_utils_mac.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/utility/importer/firefox_importer.h

diff --git a/chrome/utility/importer/firefox_importer.h b/chrome/utility/importer/firefox_importer.h

index cd513a325d4cd8872f40cd35e9f539b7a2d36a54..d4014234d93278e54be59c098d8361d90c523134 100644

--- a/chrome/utility/importer/firefox_importer.h

+++ b/chrome/utility/importer/firefox_importer.h

@@ -30,14 +30,14 @@ class FirefoxImporter : public Importer {

FirefoxImporter();

// Importer:

- virtual void StartImport(const importer::SourceProfile& source_profile,

- uint16 items,

- ImporterBridge* bridge) override;

+ void StartImport(const importer::SourceProfile& source_profile,

+ uint16 items,

+ ImporterBridge* bridge) override;

private:

typedef std::map<int64, std::set<GURL> > FaviconMap;

- virtual ~FirefoxImporter();

+ ~FirefoxImporter() override;

void ImportBookmarks();

void ImportPasswords();