chrome/service/cloud_print/cloud_print_url_fetcher.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/service/cloud_print/cloud_print_url_fetcher.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/service/cloud_print/cloud_print_proxy_backend.cc ('k') | chrome/service/cloud_print/cloud_print_url_fetcher_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/service/cloud_print/cloud_print_url_fetcher.h

diff --git a/chrome/service/cloud_print/cloud_print_url_fetcher.h b/chrome/service/cloud_print/cloud_print_url_fetcher.h

index 901d5844bbe4df01fd1e2d068a3c2a1272317c58..91cad82d3f59750c9659eee6948cab64c8be3ee4 100644

--- a/chrome/service/cloud_print/cloud_print_url_fetcher.h

+++ b/chrome/service/cloud_print/cloud_print_url_fetcher.h

@@ -134,12 +134,12 @@ class CloudPrintURLFetcher

const std::string& additional_headers);

// net::URLFetcherDelegate implementation.

- virtual void OnURLFetchComplete(const net::URLFetcher* source) override;

+ void OnURLFetchComplete(const net::URLFetcher* source) override;

protected:

CloudPrintURLFetcher();

friend class base::RefCountedThreadSafe<CloudPrintURLFetcher>;

- virtual ~CloudPrintURLFetcher();

+ ~CloudPrintURLFetcher() override;

// Virtual for testing.

virtual net::URLRequestContextGetter* GetRequestContextGetter();