Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10430)

Unified Diff: chrome/test/chromedriver/commands_unittest.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/command_listener_proxy_unittest.cc ('k') | chrome/test/chromedriver/logging.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/commands_unittest.cc
diff --git a/chrome/test/chromedriver/commands_unittest.cc b/chrome/test/chromedriver/commands_unittest.cc
index c953d19f34730b87449465c37be610b0d0e9371f..fa6bd9cb2b54f3bfab39d3fcb8e9e0344d454c66 100644
--- a/chrome/test/chromedriver/commands_unittest.cc
+++ b/chrome/test/chromedriver/commands_unittest.cc
@@ -273,7 +273,7 @@ class FindElementWebView : public StubWebView {
}
}
}
- virtual ~FindElementWebView() {}
+ ~FindElementWebView() override {}
void Verify(const std::string& expected_frame,
const base::ListValue* expected_args,
@@ -292,10 +292,10 @@ class FindElementWebView : public StubWebView {
}
// Overridden from WebView:
- virtual Status CallFunction(const std::string& frame,
- const std::string& function,
- const base::ListValue& args,
- scoped_ptr<base::Value>* result) override {
+ Status CallFunction(const std::string& frame,
+ const std::string& function,
+ const base::ListValue& args,
+ scoped_ptr<base::Value>* result) override {
++current_count_;
if (scenario_ == kElementExistsTimeout ||
(scenario_ == kElementExistsQueryTwice && current_count_ == 1)) {
@@ -501,13 +501,13 @@ class ErrorCallFunctionWebView : public StubWebView {
public:
explicit ErrorCallFunctionWebView(StatusCode code)
: StubWebView("1"), code_(code) {}
- virtual ~ErrorCallFunctionWebView() {}
+ ~ErrorCallFunctionWebView() override {}
// Overridden from WebView:
- virtual Status CallFunction(const std::string& frame,
- const std::string& function,
- const base::ListValue& args,
- scoped_ptr<base::Value>* result) override {
+ Status CallFunction(const std::string& frame,
+ const std::string& function,
+ const base::ListValue& args,
+ scoped_ptr<base::Value>* result) override {
return Status(code_);
}
@@ -553,9 +553,9 @@ namespace {
class MockCommandListener : public CommandListener {
public:
MockCommandListener() : called_(false) {}
- virtual ~MockCommandListener() {}
+ ~MockCommandListener() override {}
- virtual Status BeforeCommand(const std::string& command_name) override {
+ Status BeforeCommand(const std::string& command_name) override {
called_ = true;
EXPECT_STREQ("cmd", command_name.c_str());
return Status(kOk);
@@ -660,9 +660,9 @@ namespace {
class FailingCommandListener : public CommandListener {
public:
FailingCommandListener() {}
- virtual ~FailingCommandListener() {}
+ ~FailingCommandListener() override {}
- virtual Status BeforeCommand(const std::string& command_name) override {
+ Status BeforeCommand(const std::string& command_name) override {
return Status(kUnknownError);
}
};
« no previous file with comments | « chrome/test/chromedriver/command_listener_proxy_unittest.cc ('k') | chrome/test/chromedriver/logging.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698