Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(349)

Side by Side Diff: chrome/app/chrome_main_delegate.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.h ('k') | chrome/app_shim/chrome_main_app_mode_mac.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_APP_CHROME_MAIN_DELEGATE_H_ 5 #ifndef CHROME_APP_CHROME_MAIN_DELEGATE_H_
6 #define CHROME_APP_CHROME_MAIN_DELEGATE_H_ 6 #define CHROME_APP_CHROME_MAIN_DELEGATE_H_
7 7
8 #include "base/memory/scoped_ptr.h" 8 #include "base/memory/scoped_ptr.h"
9 #include "base/metrics/stats_counters.h" 9 #include "base/metrics/stats_counters.h"
10 #include "chrome/common/chrome_content_client.h" 10 #include "chrome/common/chrome_content_client.h"
11 #include "content/public/app/content_main_delegate.h" 11 #include "content/public/app/content_main_delegate.h"
12 12
13 template <typename> 13 template <typename>
14 class ScopedVector; 14 class ScopedVector;
15 15
16 namespace base { 16 namespace base {
17 class CommandLine; 17 class CommandLine;
18 } 18 }
19 19
20 // Chrome implementation of ContentMainDelegate. 20 // Chrome implementation of ContentMainDelegate.
21 class ChromeMainDelegate : public content::ContentMainDelegate { 21 class ChromeMainDelegate : public content::ContentMainDelegate {
22 public: 22 public:
23 ChromeMainDelegate(); 23 ChromeMainDelegate();
24 virtual ~ChromeMainDelegate(); 24 ~ChromeMainDelegate() override;
25 25
26 protected: 26 protected:
27 // content::ContentMainDelegate implementation: 27 // content::ContentMainDelegate implementation:
28 virtual bool BasicStartupComplete(int* exit_code) override; 28 bool BasicStartupComplete(int* exit_code) override;
29 virtual void PreSandboxStartup() override; 29 void PreSandboxStartup() override;
30 virtual void SandboxInitialized(const std::string& process_type) override; 30 void SandboxInitialized(const std::string& process_type) override;
31 virtual int RunProcess( 31 int RunProcess(
32 const std::string& process_type, 32 const std::string& process_type,
33 const content::MainFunctionParams& main_function_params) override; 33 const content::MainFunctionParams& main_function_params) override;
34 virtual void ProcessExiting(const std::string& process_type) override; 34 void ProcessExiting(const std::string& process_type) override;
35 #if defined(OS_MACOSX) 35 #if defined(OS_MACOSX)
36 virtual bool ProcessRegistersWithSystemProcess( 36 bool ProcessRegistersWithSystemProcess(
37 const std::string& process_type) override; 37 const std::string& process_type) override;
38 virtual bool ShouldSendMachPort(const std::string& process_type) override; 38 bool ShouldSendMachPort(const std::string& process_type) override;
39 virtual bool DelaySandboxInitialization( 39 bool DelaySandboxInitialization(const std::string& process_type) override;
40 const std::string& process_type) override;
41 #elif defined(OS_POSIX) && !defined(OS_ANDROID) 40 #elif defined(OS_POSIX) && !defined(OS_ANDROID)
42 virtual void ZygoteStarting( 41 virtual void ZygoteStarting(
43 ScopedVector<content::ZygoteForkDelegate>* delegates) override; 42 ScopedVector<content::ZygoteForkDelegate>* delegates) override;
44 virtual void ZygoteForked() override; 43 virtual void ZygoteForked() override;
45 #elif defined(OS_WIN) 44 #elif defined(OS_WIN)
46 virtual bool ShouldEnableTerminationOnHeapCorruption() override; 45 virtual bool ShouldEnableTerminationOnHeapCorruption() override;
47 #endif 46 #endif
48 47
49 virtual content::ContentBrowserClient* CreateContentBrowserClient() override; 48 content::ContentBrowserClient* CreateContentBrowserClient() override;
50 virtual content::ContentPluginClient* CreateContentPluginClient() override; 49 content::ContentPluginClient* CreateContentPluginClient() override;
51 virtual content::ContentRendererClient* 50 content::ContentRendererClient* CreateContentRendererClient() override;
52 CreateContentRendererClient() override; 51 content::ContentUtilityClient* CreateContentUtilityClient() override;
53 virtual content::ContentUtilityClient* CreateContentUtilityClient() override;
54 52
55 #if defined(OS_MACOSX) 53 #if defined(OS_MACOSX)
56 void InitMacCrashReporter(const base::CommandLine& command_line, 54 void InitMacCrashReporter(const base::CommandLine& command_line,
57 const std::string& process_type); 55 const std::string& process_type);
58 #endif // defined(OS_MACOSX) 56 #endif // defined(OS_MACOSX)
59 57
60 ChromeContentClient chrome_content_client_; 58 ChromeContentClient chrome_content_client_;
61 59
62 // startup_timer_ will hold a reference to stats_counter_timer_. Therefore, 60 // startup_timer_ will hold a reference to stats_counter_timer_. Therefore,
63 // the declaration order of these variables matters. Changing this order will 61 // the declaration order of these variables matters. Changing this order will
64 // cause startup_timer_ to be freed before stats_counter_timer_, leaving a 62 // cause startup_timer_ to be freed before stats_counter_timer_, leaving a
65 // dangling reference. 63 // dangling reference.
66 scoped_ptr<base::StatsCounterTimer> stats_counter_timer_; 64 scoped_ptr<base::StatsCounterTimer> stats_counter_timer_;
67 scoped_ptr<base::StatsScope<base::StatsCounterTimer> > startup_timer_; 65 scoped_ptr<base::StatsScope<base::StatsCounterTimer> > startup_timer_;
68 66
69 DISALLOW_COPY_AND_ASSIGN(ChromeMainDelegate); 67 DISALLOW_COPY_AND_ASSIGN(ChromeMainDelegate);
70 }; 68 };
71 69
72 #endif // CHROME_APP_CHROME_MAIN_DELEGATE_H_ 70 #endif // CHROME_APP_CHROME_MAIN_DELEGATE_H_
OLDNEW
« no previous file with comments | « chrome/app/chrome_crash_reporter_client.h ('k') | chrome/app_shim/chrome_main_app_mode_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698