Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1129)

Unified Diff: chrome/test/chromedriver/logging.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/net/net_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/logging.h
diff --git a/chrome/test/chromedriver/logging.h b/chrome/test/chromedriver/logging.h
index 83b6d1095a138455dd80ca299217dd9658ed0215..7b923e733d00e1d92241f735a8d4d8d953842918 100644
--- a/chrome/test/chromedriver/logging.h
+++ b/chrome/test/chromedriver/logging.h
@@ -33,7 +33,7 @@ class WebDriverLog : public Log {
// Creates a WebDriverLog with the given type and minimum level.
WebDriverLog(const std::string& type, Level min_level);
- virtual ~WebDriverLog();
+ ~WebDriverLog() override;
// Returns entries accumulated so far, as a ListValue ready for serialization
// into the wire protocol response to the "/log" command.
@@ -46,10 +46,10 @@ class WebDriverLog : public Log {
std::string GetFirstErrorMessage() const;
// Translates a Log entry level into a WebDriver level and stores the entry.
- virtual void AddEntryTimestamped(const base::Time& timestamp,
- Level level,
- const std::string& source,
- const std::string& message) override;
+ void AddEntryTimestamped(const base::Time& timestamp,
+ Level level,
+ const std::string& source,
+ const std::string& message) override;
const std::string& type() const;
void set_min_level(Level min_level);
« no previous file with comments | « chrome/test/chromedriver/commands_unittest.cc ('k') | chrome/test/chromedriver/net/net_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698