Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(786)

Side by Side Diff: chrome/test/chromedriver/net/net_util.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/test/chromedriver/logging.h ('k') | chrome/test/chromedriver/net/net_util_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/net/net_util.h" 5 #include "chrome/test/chromedriver/net/net_util.h"
6 6
7 #include "base/basictypes.h" 7 #include "base/basictypes.h"
8 #include "base/bind.h" 8 #include "base/bind.h"
9 #include "base/bind_helpers.h" 9 #include "base/bind_helpers.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "base/message_loop/message_loop.h" 12 #include "base/message_loop/message_loop.h"
13 #include "base/strings/stringprintf.h" 13 #include "base/strings/stringprintf.h"
14 #include "base/synchronization/waitable_event.h" 14 #include "base/synchronization/waitable_event.h"
15 #include "chrome/test/chromedriver/net/url_request_context_getter.h" 15 #include "chrome/test/chromedriver/net/url_request_context_getter.h"
16 #include "net/url_request/url_fetcher.h" 16 #include "net/url_request/url_fetcher.h"
17 #include "net/url_request/url_fetcher_delegate.h" 17 #include "net/url_request/url_fetcher_delegate.h"
18 #include "url/gurl.h" 18 #include "url/gurl.h"
19 19
20 namespace { 20 namespace {
21 21
22 class SyncUrlFetcher : public net::URLFetcherDelegate { 22 class SyncUrlFetcher : public net::URLFetcherDelegate {
23 public: 23 public:
24 SyncUrlFetcher(const GURL& url, 24 SyncUrlFetcher(const GURL& url,
25 URLRequestContextGetter* getter, 25 URLRequestContextGetter* getter,
26 std::string* response) 26 std::string* response)
27 : url_(url), getter_(getter), response_(response), event_(false, false) {} 27 : url_(url), getter_(getter), response_(response), event_(false, false) {}
28 28
29 virtual ~SyncUrlFetcher() {} 29 ~SyncUrlFetcher() override {}
30 30
31 bool Fetch() { 31 bool Fetch() {
32 getter_->GetNetworkTaskRunner()->PostTask( 32 getter_->GetNetworkTaskRunner()->PostTask(
33 FROM_HERE, 33 FROM_HERE,
34 base::Bind(&SyncUrlFetcher::FetchOnIOThread, base::Unretained(this))); 34 base::Bind(&SyncUrlFetcher::FetchOnIOThread, base::Unretained(this)));
35 event_.Wait(); 35 event_.Wait();
36 return success_; 36 return success_;
37 } 37 }
38 38
39 void FetchOnIOThread() { 39 void FetchOnIOThread() {
40 fetcher_.reset(net::URLFetcher::Create(url_, net::URLFetcher::GET, this)); 40 fetcher_.reset(net::URLFetcher::Create(url_, net::URLFetcher::GET, this));
41 fetcher_->SetRequestContext(getter_); 41 fetcher_->SetRequestContext(getter_);
42 fetcher_->Start(); 42 fetcher_->Start();
43 } 43 }
44 44
45 virtual void OnURLFetchComplete(const net::URLFetcher* source) override { 45 void OnURLFetchComplete(const net::URLFetcher* source) override {
46 success_ = (source->GetResponseCode() == 200); 46 success_ = (source->GetResponseCode() == 200);
47 if (success_) 47 if (success_)
48 success_ = source->GetResponseAsString(response_); 48 success_ = source->GetResponseAsString(response_);
49 fetcher_.reset(); // Destroy the fetcher on IO thread. 49 fetcher_.reset(); // Destroy the fetcher on IO thread.
50 event_.Signal(); 50 event_.Signal();
51 } 51 }
52 52
53 private: 53 private:
54 GURL url_; 54 GURL url_;
55 URLRequestContextGetter* getter_; 55 URLRequestContextGetter* getter_;
(...skipping 28 matching lines...) Expand all
84 84
85 int NetAddress::port() const { 85 int NetAddress::port() const {
86 return port_; 86 return port_;
87 } 87 }
88 88
89 bool FetchUrl(const std::string& url, 89 bool FetchUrl(const std::string& url,
90 URLRequestContextGetter* getter, 90 URLRequestContextGetter* getter,
91 std::string* response) { 91 std::string* response) {
92 return SyncUrlFetcher(GURL(url), getter, response).Fetch(); 92 return SyncUrlFetcher(GURL(url), getter, response).Fetch();
93 } 93 }
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/logging.h ('k') | chrome/test/chromedriver/net/net_util_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698