Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Side by Side Diff: chrome/test/chromedriver/net/sync_websocket_impl.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_TEST_CHROMEDRIVER_NET_SYNC_WEBSOCKET_IMPL_H_ 5 #ifndef CHROME_TEST_CHROMEDRIVER_NET_SYNC_WEBSOCKET_IMPL_H_
6 #define CHROME_TEST_CHROMEDRIVER_NET_SYNC_WEBSOCKET_IMPL_H_ 6 #define CHROME_TEST_CHROMEDRIVER_NET_SYNC_WEBSOCKET_IMPL_H_
7 7
8 #include <list> 8 #include <list>
9 #include <string> 9 #include <string>
10 10
(...skipping 14 matching lines...) Expand all
25 25
26 namespace net { 26 namespace net {
27 class URLRequestContextGetter; 27 class URLRequestContextGetter;
28 } 28 }
29 29
30 class GURL; 30 class GURL;
31 31
32 class SyncWebSocketImpl : public SyncWebSocket { 32 class SyncWebSocketImpl : public SyncWebSocket {
33 public: 33 public:
34 explicit SyncWebSocketImpl(net::URLRequestContextGetter* context_getter); 34 explicit SyncWebSocketImpl(net::URLRequestContextGetter* context_getter);
35 virtual ~SyncWebSocketImpl(); 35 ~SyncWebSocketImpl() override;
36 36
37 // Overridden from SyncWebSocket: 37 // Overridden from SyncWebSocket:
38 virtual bool IsConnected() override; 38 bool IsConnected() override;
39 virtual bool Connect(const GURL& url) override; 39 bool Connect(const GURL& url) override;
40 virtual bool Send(const std::string& message) override; 40 bool Send(const std::string& message) override;
41 virtual StatusCode ReceiveNextMessage( 41 StatusCode ReceiveNextMessage(std::string* message,
42 std::string* message, 42 const base::TimeDelta& timeout) override;
43 const base::TimeDelta& timeout) override; 43 bool HasNextMessage() override;
44 virtual bool HasNextMessage() override;
45 44
46 private: 45 private:
47 struct CoreTraits; 46 struct CoreTraits;
48 class Core : public WebSocketListener, 47 class Core : public WebSocketListener,
49 public base::RefCountedThreadSafe<Core, CoreTraits> { 48 public base::RefCountedThreadSafe<Core, CoreTraits> {
50 public: 49 public:
51 explicit Core(net::URLRequestContextGetter* context_getter); 50 explicit Core(net::URLRequestContextGetter* context_getter);
52 51
53 bool IsConnected(); 52 bool IsConnected();
54 bool Connect(const GURL& url); 53 bool Connect(const GURL& url);
55 bool Send(const std::string& message); 54 bool Send(const std::string& message);
56 SyncWebSocket::StatusCode ReceiveNextMessage( 55 SyncWebSocket::StatusCode ReceiveNextMessage(
57 std::string* message, 56 std::string* message,
58 const base::TimeDelta& timeout); 57 const base::TimeDelta& timeout);
59 bool HasNextMessage(); 58 bool HasNextMessage();
60 59
61 // Overriden from WebSocketListener: 60 // Overriden from WebSocketListener:
62 virtual void OnMessageReceived(const std::string& message) override; 61 void OnMessageReceived(const std::string& message) override;
63 virtual void OnClose() override; 62 void OnClose() override;
64 63
65 private: 64 private:
66 friend class base::RefCountedThreadSafe<Core, CoreTraits>; 65 friend class base::RefCountedThreadSafe<Core, CoreTraits>;
67 friend class base::DeleteHelper<Core>; 66 friend class base::DeleteHelper<Core>;
68 friend struct CoreTraits; 67 friend struct CoreTraits;
69 68
70 virtual ~Core(); 69 ~Core() override;
71 70
72 void ConnectOnIO(const GURL& url, 71 void ConnectOnIO(const GURL& url,
73 bool* success, 72 bool* success,
74 base::WaitableEvent* event); 73 base::WaitableEvent* event);
75 void OnConnectCompletedOnIO(bool* connected, 74 void OnConnectCompletedOnIO(bool* connected,
76 base::WaitableEvent* event, 75 base::WaitableEvent* event,
77 int error); 76 int error);
78 void SendOnIO(const std::string& message, 77 void SendOnIO(const std::string& message,
79 bool* result, 78 bool* result,
80 base::WaitableEvent* event); 79 base::WaitableEvent* event);
(...skipping 22 matching lines...) Expand all
103 scoped_refptr<Core> core_; 102 scoped_refptr<Core> core_;
104 }; 103 };
105 104
106 struct SyncWebSocketImpl::CoreTraits { 105 struct SyncWebSocketImpl::CoreTraits {
107 static void Destruct(const SyncWebSocketImpl::Core* core) { 106 static void Destruct(const SyncWebSocketImpl::Core* core) {
108 core->OnDestruct(); 107 core->OnDestruct();
109 } 108 }
110 }; 109 };
111 110
112 #endif // CHROME_TEST_CHROMEDRIVER_NET_SYNC_WEBSOCKET_IMPL_H_ 111 #endif // CHROME_TEST_CHROMEDRIVER_NET_SYNC_WEBSOCKET_IMPL_H_
OLDNEW
« no previous file with comments | « chrome/test/chromedriver/net/net_util_unittest.cc ('k') | chrome/test/chromedriver/net/test_http_server.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698