Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(515)

Unified Diff: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/utility/importer/firefox_importer.h ('k') | chrome/utility/importer/safari_importer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
diff --git a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
index 782acaceb12329418e53f99efb94cd552f43d445..2ae60eaaadb35b53910baace90dea717c8e8eca3 100644
--- a/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
+++ b/chrome/utility/importer/firefox_importer_unittest_utils_mac.cc
@@ -103,7 +103,7 @@ class FFDecryptorServerChannelListener : public IPC::Listener {
sender_->Send(new Msg_Decryptor_Quit());
}
- virtual bool OnMessageReceived(const IPC::Message& msg) override {
+ bool OnMessageReceived(const IPC::Message& msg) override {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(FFDecryptorServerChannelListener, msg)
IPC_MESSAGE_HANDLER(Msg_Decryptor_InitReturnCode, OnInitDecryptorResponse)
@@ -115,7 +115,7 @@ class FFDecryptorServerChannelListener : public IPC::Listener {
}
// If an error occured, just kill the message Loop.
- virtual void OnChannelError() override {
+ void OnChannelError() override {
got_result = false;
base::MessageLoop::current()->Quit();
}
@@ -264,7 +264,7 @@ class FFDecryptorClientChannelListener : public IPC::Listener {
base::MessageLoop::current()->Quit();
}
- virtual bool OnMessageReceived(const IPC::Message& msg) override {
+ bool OnMessageReceived(const IPC::Message& msg) override {
bool handled = true;
IPC_BEGIN_MESSAGE_MAP(FFDecryptorClientChannelListener, msg)
IPC_MESSAGE_HANDLER(Msg_Decryptor_Init, OnDecryptor_Init)
@@ -276,9 +276,7 @@ class FFDecryptorClientChannelListener : public IPC::Listener {
return handled;
}
- virtual void OnChannelError() override {
- base::MessageLoop::current()->Quit();
- }
+ void OnChannelError() override { base::MessageLoop::current()->Quit(); }
private:
NSSDecryptor decryptor_;
« no previous file with comments | « chrome/utility/importer/firefox_importer.h ('k') | chrome/utility/importer/safari_importer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698