chrome/common/extensions/chrome_manifest_url_handlers.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/chrome_manifest_url_handlers.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/chrome_extensions_client.h ('k') | chrome/common/extensions/features/chrome_channel_feature_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/chrome_manifest_url_handlers.h

diff --git a/chrome/common/extensions/chrome_manifest_url_handlers.h b/chrome/common/extensions/chrome_manifest_url_handlers.h

index ab56a1d18f6602ce0237d9ddefe3731398529908..396fb42cc4e635800b6e3e38c25897240876cb59 100644

--- a/chrome/common/extensions/chrome_manifest_url_handlers.h

+++ b/chrome/common/extensions/chrome_manifest_url_handlers.h

@@ -27,7 +27,7 @@ struct URLOverrides : public Extension::ManifestData {

typedef std::map<const std::string, GURL> URLOverrideMap;

URLOverrides();

- virtual ~URLOverrides();

+ ~URLOverrides() override;

static const URLOverrideMap& GetChromeURLOverrides(

const Extension* extension);

@@ -41,12 +41,12 @@ struct URLOverrides : public Extension::ManifestData {

class DevToolsPageHandler : public ManifestHandler {

public:

DevToolsPageHandler();

- virtual ~DevToolsPageHandler();

+ ~DevToolsPageHandler() override;

- virtual bool Parse(Extension* extension, base::string16* error) override;

+ bool Parse(Extension* extension, base::string16* error) override;

private:

- virtual const std::vector<std::string> Keys() const override;

+ const std::vector<std::string> Keys() const override;

DISALLOW_COPY_AND_ASSIGN(DevToolsPageHandler);

};

@@ -55,12 +55,12 @@ class DevToolsPageHandler : public ManifestHandler {

class URLOverridesHandler : public ManifestHandler {

public:

URLOverridesHandler();

- virtual ~URLOverridesHandler();

+ ~URLOverridesHandler() override;

- virtual bool Parse(Extension* extension, base::string16* error) override;

+ bool Parse(Extension* extension, base::string16* error) override;

private:

- virtual const std::vector<std::string> Keys() const override;

+ const std::vector<std::string> Keys() const override;

DISALLOW_COPY_AND_ASSIGN(URLOverridesHandler);

};