Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: chrome/utility/media_galleries/itunes_library_parser.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/utility/media_galleries/itunes_library_parser.cc
diff --git a/chrome/utility/media_galleries/itunes_library_parser.cc b/chrome/utility/media_galleries/itunes_library_parser.cc
index 60f2809f7223ede8fa128c8de70a1f55daec49e3..bf23e6be51d03e9a77c8174631cbbfe185fb4f23 100644
--- a/chrome/utility/media_galleries/itunes_library_parser.cc
+++ b/chrome/utility/media_galleries/itunes_library_parser.cc
@@ -32,12 +32,12 @@ class TrackInfoXmlDictReader : public iapps::XmlDictReader {
TrackInfoXmlDictReader(XmlReader* reader, TrackInfo* track_info) :
iapps::XmlDictReader(reader), track_info_(track_info) {}
- virtual bool ShouldLoop() override {
+ bool ShouldLoop() override {
return !(Found("Track ID") && Found("Location") &&
Found("Album Artist") && Found("Album"));
}
- virtual bool HandleKeyImpl(const std::string& key) override {
+ bool HandleKeyImpl(const std::string& key) override {
if (key == "Track ID") {
return iapps::ReadInteger(reader_, &track_info_->id);
} else if (key == "Location") {
@@ -75,9 +75,7 @@ class TrackInfoXmlDictReader : public iapps::XmlDictReader {
return true;
}
- virtual bool FinishedOk() override {
- return Found("Track ID") && Found("Location");
- }
+ bool FinishedOk() override { return Found("Track ID") && Found("Location"); }
private:
TrackInfo* track_info_;
« no previous file with comments | « chrome/utility/media_galleries/iphoto_library_parser.cc ('k') | chrome/utility/media_galleries/picasa_albums_indexer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698