chrome/common/extensions/manifest_handlers/extension_action_handler.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/manifest_handlers/extension_action_handler.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/manifest_handlers/content_scripts_handler.h ('k') | chrome/common/extensions/manifest_handlers/mime_types_handler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/manifest_handlers/extension_action_handler.h

diff --git a/chrome/common/extensions/manifest_handlers/extension_action_handler.h b/chrome/common/extensions/manifest_handlers/extension_action_handler.h

index 3c03ef9b24bec4ac199f9c3a883d00743d462440..48441b3bbadcdf8a6360aa92c23c15c4d45b9037 100644

--- a/chrome/common/extensions/manifest_handlers/extension_action_handler.h

+++ b/chrome/common/extensions/manifest_handlers/extension_action_handler.h

@@ -15,16 +15,16 @@ namespace extensions {

class ExtensionActionHandler : public ManifestHandler {

public:

ExtensionActionHandler();

- virtual ~ExtensionActionHandler();

+ ~ExtensionActionHandler() override;

- virtual bool Parse(Extension* extension, base::string16* error) override;

- virtual bool Validate(const Extension* extension,

- std::string* error,

- std::vector<InstallWarning>* warnings) const override;

+ bool Parse(Extension* extension, base::string16* error) override;

+ bool Validate(const Extension* extension,

+ std::string* error,

+ std::vector<InstallWarning>* warnings) const override;

private:

- virtual bool AlwaysParseForType(Manifest::Type type) const override;

- virtual const std::vector<std::string> Keys() const override;

+ bool AlwaysParseForType(Manifest::Type type) const override;

+ const std::vector<std::string> Keys() const override;

DISALLOW_COPY_AND_ASSIGN(ExtensionActionHandler);

};