Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: chrome/test/chromedriver/chrome/stub_devtools_client.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/chrome/stub_chrome.h ('k') | chrome/test/chromedriver/chrome/stub_web_view.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/chrome/stub_devtools_client.h
diff --git a/chrome/test/chromedriver/chrome/stub_devtools_client.h b/chrome/test/chromedriver/chrome/stub_devtools_client.h
index 66d01f8dcc26c612b1009e9f1fc32702684841c9..6fab0ad590a47380d4d32a9b6008ce41412aa807 100644
--- a/chrome/test/chromedriver/chrome/stub_devtools_client.h
+++ b/chrome/test/chromedriver/chrome/stub_devtools_client.h
@@ -22,22 +22,22 @@ class StubDevToolsClient : public DevToolsClient {
public:
explicit StubDevToolsClient(const std::string& id);
StubDevToolsClient();
- virtual ~StubDevToolsClient();
+ ~StubDevToolsClient() override;
// Overridden from DevToolsClient:
- virtual const std::string& GetId() override;
- virtual bool WasCrashed() override;
- virtual Status ConnectIfNecessary() override;
- virtual Status SendCommand(const std::string& method,
- const base::DictionaryValue& params) override;
- virtual Status SendCommandAndGetResult(
+ const std::string& GetId() override;
+ bool WasCrashed() override;
+ Status ConnectIfNecessary() override;
+ Status SendCommand(const std::string& method,
+ const base::DictionaryValue& params) override;
+ Status SendCommandAndGetResult(
const std::string& method,
const base::DictionaryValue& params,
scoped_ptr<base::DictionaryValue>* result) override;
- virtual void AddListener(DevToolsEventListener* listener) override;
- virtual Status HandleEventsUntil(const ConditionalFunc& conditional_func,
- const base::TimeDelta& timeout) override;
- virtual Status HandleReceivedEvents() override;
+ void AddListener(DevToolsEventListener* listener) override;
+ Status HandleEventsUntil(const ConditionalFunc& conditional_func,
+ const base::TimeDelta& timeout) override;
+ Status HandleReceivedEvents() override;
protected:
const std::string id_;
« no previous file with comments | « chrome/test/chromedriver/chrome/stub_chrome.h ('k') | chrome/test/chromedriver/chrome/stub_web_view.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698