chrome/app_shim/chrome_main_app_mode_mac.mm - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/app_shim/chrome_main_app_mode_mac.mm

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/app_shim/chrome_main_app_mode_mac.mm

diff --git a/chrome/app_shim/chrome_main_app_mode_mac.mm b/chrome/app_shim/chrome_main_app_mode_mac.mm

index 4e300ac0466e9415000005c7fd17f3c6a717d4f6..5692f7e66d23fb1ccf2200e7b6952551cabbbc1a 100644

--- a/chrome/app_shim/chrome_main_app_mode_mac.mm

+++ b/chrome/app_shim/chrome_main_app_mode_mac.mm

@@ -88,7 +88,7 @@ class AppShimController;

class AppShimController : public IPC::Listener {

public:

AppShimController();

- virtual ~AppShimController();

+ ~AppShimController() override;

// Called when the main Chrome process responds to the Apple Event ping that

// was sent, or when the ping fails (if |success| is false).

@@ -119,8 +119,8 @@ class AppShimController : public IPC::Listener {

private:

// IPC::Listener implemetation.

- virtual bool OnMessageReceived(const IPC::Message& message) override;

- virtual void OnChannelError() override;

+ bool OnMessageReceived(const IPC::Message& message) override;

+ void OnChannelError() override;

// If Chrome failed to launch the app, |success| will be false and the app

// shim process should die.

« no previous file with comments | « chrome/app/chrome_main_delegate.h ('k') | chrome/common/chrome_content_client.h » ('j') | no next file with comments »