Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5083)

Unified Diff: chrome/test/chromedriver/server/chromedriver_server.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/server/chromedriver_server.cc
diff --git a/chrome/test/chromedriver/server/chromedriver_server.cc b/chrome/test/chromedriver/server/chromedriver_server.cc
index 432d6ef931b264c1e76e08bebb91bfc9060e9144..9684e3c05a6fa183a2c2e5714c923bb3ab72b4d5 100644
--- a/chrome/test/chromedriver/server/chromedriver_server.cc
+++ b/chrome/test/chromedriver/server/chromedriver_server.cc
@@ -65,24 +65,23 @@ class HttpServer : public net::HttpServer::Delegate {
}
// Overridden from net::HttpServer::Delegate:
- virtual void OnConnect(int connection_id) override {
+ void OnConnect(int connection_id) override {
server_->SetSendBufferSize(connection_id, kBufferSize);
server_->SetReceiveBufferSize(connection_id, kBufferSize);
}
- virtual void OnHttpRequest(int connection_id,
- const net::HttpServerRequestInfo& info) override {
+ void OnHttpRequest(int connection_id,
+ const net::HttpServerRequestInfo& info) override {
handle_request_func_.Run(
info,
base::Bind(&HttpServer::OnResponse,
weak_factory_.GetWeakPtr(),
connection_id));
}
- virtual void OnWebSocketRequest(
- int connection_id,
- const net::HttpServerRequestInfo& info) override {}
- virtual void OnWebSocketMessage(int connection_id,
- const std::string& data) override {}
- virtual void OnClose(int connection_id) override {}
+ void OnWebSocketRequest(int connection_id,
+ const net::HttpServerRequestInfo& info) override {}
+ void OnWebSocketMessage(int connection_id, const std::string& data) override {
+ }
+ void OnClose(int connection_id) override {}
private:
void OnResponse(int connection_id,
« no previous file with comments | « chrome/test/chromedriver/performance_logger_unittest.cc ('k') | chrome/test/chromedriver/session_commands_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698