Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1376)

Unified Diff: chrome/test/chromedriver/chrome/device_manager_unittest.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/chrome/device_manager_unittest.cc
diff --git a/chrome/test/chromedriver/chrome/device_manager_unittest.cc b/chrome/test/chromedriver/chrome/device_manager_unittest.cc
index b6003889872529ac4e3dd528586c06541e77a292..be6f2793251f6923a7a3ca7c6fa510a69be12537 100644
--- a/chrome/test/chromedriver/chrome/device_manager_unittest.cc
+++ b/chrome/test/chromedriver/chrome/device_manager_unittest.cc
@@ -17,56 +17,56 @@ namespace {
class FakeAdb : public Adb {
public:
FakeAdb() {}
- virtual ~FakeAdb() {}
+ ~FakeAdb() override {}
- virtual Status GetDevices(std::vector<std::string>* devices) override {
+ Status GetDevices(std::vector<std::string>* devices) override {
devices->push_back("a");
devices->push_back("b");
return Status(kOk);
}
- virtual Status ForwardPort(const std::string& device_serial,
- int local_port,
- const std::string& remote_abstract) override {
+ Status ForwardPort(const std::string& device_serial,
+ int local_port,
+ const std::string& remote_abstract) override {
return Status(kOk);
}
- virtual Status SetCommandLineFile(const std::string& device_serial,
- const std::string& command_line_file,
- const std::string& exec_name,
- const std::string& args) override {
+ Status SetCommandLineFile(const std::string& device_serial,
+ const std::string& command_line_file,
+ const std::string& exec_name,
+ const std::string& args) override {
return Status(kOk);
}
- virtual Status CheckAppInstalled(const std::string& device_serial,
- const std::string& package) override {
+ Status CheckAppInstalled(const std::string& device_serial,
+ const std::string& package) override {
return Status(kOk);
}
- virtual Status ClearAppData(const std::string& device_serial,
- const std::string& package) override {
+ Status ClearAppData(const std::string& device_serial,
+ const std::string& package) override {
return Status(kOk);
}
- virtual Status SetDebugApp(const std::string& device_serial,
- const std::string& package) override {
+ Status SetDebugApp(const std::string& device_serial,
+ const std::string& package) override {
return Status(kOk);
}
- virtual Status Launch(const std::string& device_serial,
- const std::string& package,
- const std::string& activity) override {
+ Status Launch(const std::string& device_serial,
+ const std::string& package,
+ const std::string& activity) override {
return Status(kOk);
}
- virtual Status ForceStop(const std::string& device_serial,
- const std::string& package) override {
+ Status ForceStop(const std::string& device_serial,
+ const std::string& package) override {
return Status(kOk);
}
- virtual Status GetPidByName(const std::string& device_serial,
- const std::string& process_name,
- int* pid) override {
+ Status GetPidByName(const std::string& device_serial,
+ const std::string& process_name,
+ int* pid) override {
*pid = 0; // avoid uninit error crbug.com/393231
return Status(kOk);
}
« no previous file with comments | « chrome/test/chromedriver/chrome/debugger_tracker.h ('k') | chrome/test/chromedriver/chrome/devtools_client_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698