chrome/common/extensions/features/chrome_channel_feature_filter.h - Issue 653773004: Standardize usage of virtual/override/final in chrome/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/common/extensions/features/chrome_channel_feature_filter.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/chrome_manifest_url_handlers.h ('k') | chrome/common/extensions/manifest_handlers/app_isolation_info.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/common/extensions/features/chrome_channel_feature_filter.h

diff --git a/chrome/common/extensions/features/chrome_channel_feature_filter.h b/chrome/common/extensions/features/chrome_channel_feature_filter.h

index 55f24410b0b307515d337108ad9fa5b1d93cf343..4394f56b9379d3da611d4f32d9beadaacceaadc6 100644

--- a/chrome/common/extensions/features/chrome_channel_feature_filter.h

+++ b/chrome/common/extensions/features/chrome_channel_feature_filter.h

@@ -15,11 +15,11 @@ namespace extensions {

class ChromeChannelFeatureFilter : public SimpleFeatureFilter {

public:

explicit ChromeChannelFeatureFilter(SimpleFeature* feature);

- virtual ~ChromeChannelFeatureFilter();

+ ~ChromeChannelFeatureFilter() override;

// SimpleFeatureFilter implementation.

- virtual std::string Parse(const base::DictionaryValue* value) override;

- virtual Feature::Availability IsAvailableToManifest(

+ std::string Parse(const base::DictionaryValue* value) override;

+ Feature::Availability IsAvailableToManifest(

const std::string& extension_id,

Manifest::Type type,

Manifest::Location location,