Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6605)

Unified Diff: chrome/test/chromedriver/net/websocket_unittest.cc

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/chromedriver/net/websocket_unittest.cc
diff --git a/chrome/test/chromedriver/net/websocket_unittest.cc b/chrome/test/chromedriver/net/websocket_unittest.cc
index d03228770db35ae9fa7c2ca55ed30dae9aa9b549..424ccdfd3504c7d6509d6020226ed2acde922e32 100644
--- a/chrome/test/chromedriver/net/websocket_unittest.cc
+++ b/chrome/test/chromedriver/net/websocket_unittest.cc
@@ -40,11 +40,9 @@ class Listener : public WebSocketListener {
explicit Listener(const std::vector<std::string>& messages)
: messages_(messages) {}
- virtual ~Listener() {
- EXPECT_TRUE(messages_.empty());
- }
+ ~Listener() override { EXPECT_TRUE(messages_.empty()); }
- virtual void OnMessageReceived(const std::string& message) override {
+ void OnMessageReceived(const std::string& message) override {
ASSERT_TRUE(messages_.size());
EXPECT_EQ(messages_[0], message);
messages_.erase(messages_.begin());
@@ -52,9 +50,7 @@ class Listener : public WebSocketListener {
base::MessageLoop::current()->Quit();
}
- virtual void OnClose() override {
- EXPECT_TRUE(false);
- }
+ void OnClose() override { EXPECT_TRUE(false); }
private:
std::vector<std::string> messages_;
@@ -65,13 +61,11 @@ class CloseListener : public WebSocketListener {
explicit CloseListener(base::RunLoop* run_loop)
: run_loop_(run_loop) {}
- virtual ~CloseListener() {
- EXPECT_FALSE(run_loop_);
- }
+ ~CloseListener() override { EXPECT_FALSE(run_loop_); }
- virtual void OnMessageReceived(const std::string& message) override {}
+ void OnMessageReceived(const std::string& message) override {}
- virtual void OnClose() override {
+ void OnClose() override {
EXPECT_TRUE(run_loop_);
if (run_loop_)
run_loop_->Quit();
« no previous file with comments | « chrome/test/chromedriver/net/url_request_context_getter.h ('k') | chrome/test/chromedriver/performance_logger.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698