Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(754)

Unified Diff: chrome/common/extensions/api/commands/commands_handler.h

Issue 653773004: Standardize usage of virtual/override/final in chrome/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/chrome_content_client.h ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/extensions/api/commands/commands_handler.h
diff --git a/chrome/common/extensions/api/commands/commands_handler.h b/chrome/common/extensions/api/commands/commands_handler.h
index 37315225c9d96d95f52e41e1db9969ca35292f81..ddd33481c42cd1cd35ae1d7dcc3c0635ca417d93 100644
--- a/chrome/common/extensions/api/commands/commands_handler.h
+++ b/chrome/common/extensions/api/commands/commands_handler.h
@@ -17,7 +17,7 @@ namespace extensions {
struct CommandsInfo : public Extension::ManifestData {
CommandsInfo();
- virtual ~CommandsInfo();
+ ~CommandsInfo() override;
// Optional list of commands (keyboard shortcuts).
// These commands are the commands which the extension wants to use, which are
@@ -36,10 +36,10 @@ struct CommandsInfo : public Extension::ManifestData {
class CommandsHandler : public ManifestHandler {
public:
CommandsHandler();
- virtual ~CommandsHandler();
+ ~CommandsHandler() override;
- virtual bool Parse(Extension* extension, base::string16* error) override;
- virtual bool AlwaysParseForType(Manifest::Type type) const override;
+ bool Parse(Extension* extension, base::string16* error) override;
+ bool AlwaysParseForType(Manifest::Type type) const override;
private:
// If the extension defines a browser action, but no command for it, then
@@ -48,7 +48,7 @@ class CommandsHandler : public ManifestHandler {
void MaybeSetBrowserActionDefault(const Extension* extension,
CommandsInfo* info);
- virtual const std::vector<std::string> Keys() const override;
+ const std::vector<std::string> Keys() const override;
DISALLOW_COPY_AND_ASSIGN(CommandsHandler);
};
« no previous file with comments | « chrome/common/chrome_content_client.h ('k') | chrome/common/extensions/api/extension_action/action_info.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698